Feature/anchor regexp #70
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… output to work with both openssl 1.0 and openssl 1.1 formatting
8 tasks
5 tasks
jspaleta
added a commit
that referenced
this pull request
Jun 25, 2020
majormoses
reviewed
Jun 26, 2020
| @@ -102,8 +102,8 @@ def run | |||
| puts config[:regexp] | |||
| # rubocop:disable Style/IfInsideElse | |||
| if config[:regexp] | |||
| ra = Regexp.new(config[:anchor].to_s) | |||
| if data[-1] =~ ra | |||
| anchor_regexp = Regexp.new(config[:anchor].to_s) | |||
There was a problem hiding this comment.
much clearer as to its intent, thank you I know its a bit nit picky...
majormoses
pushed a commit
that referenced
this pull request
Jun 28, 2020
#71) * Add option to treat anchor as a regexp. Fix parsing of openssl client output to work with both openssl 1.0 and openssl 1.1 formatting * updates to make travis and rubocop happy * Add pure ruby implementation of check-ssl-root-issuer.rb as alternative to check-ssl-anchor.rb * make rubocop happy * add test for check-ssl-root-issuer * update changelog and README with new plugin information * remove files changed in PR #70, unrelated to this new feature * Update logic for validating issuer name format options. Using mixin libraries internal validation for allowed values.
phumpal
pushed a commit
to phumpal/sensu-plugins-ssl
that referenced
this pull request
Dec 2, 2022
sensu-plugins#71) * Add option to treat anchor as a regexp. Fix parsing of openssl client output to work with both openssl 1.0 and openssl 1.1 formatting * updates to make travis and rubocop happy * Add pure ruby implementation of check-ssl-root-issuer.rb as alternative to check-ssl-anchor.rb * make rubocop happy * add test for check-ssl-root-issuer * update changelog and README with new plugin information * remove files changed in PR sensu-plugins#70, unrelated to this new feature * Update logic for validating issuer name format options. Using mixin libraries internal validation for allowed values.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
Pull request to address failing errors found in the effort in #67
General
Two failing tests
openssl client connection certificate chain formatting has changed betwen openssl 1.0 and openssl 1.1
This causes the anchor test to fail and on examination would cause all anchor checks to fail on hosts using openssel 1.1
the check-ssl-hsts-preloadable.rb warning test no longer works because the online lookup at hstspreload.org has no reliable warning example.
Fix includes.
Misc other changes:
the check-ssl-anchor.rb command
RuboCop passes
Existing tests pass